zhangshenghang commented on code in PR #10122:
URL: https://github.com/apache/seatunnel/pull/10122#discussion_r2592957102
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcCommonOptions.java:
##########
@@ -144,6 +144,16 @@ public class JdbcCommonOptions {
public static final Option<String> REGION =
Options.key("region").stringType().noDefaultValue().withDescription("region");
+ public static final Option<String> SERVER_TIME_ZONE =
+ Options.key("server_time_zone")
+ .stringType()
+ .noDefaultValue()
+ .withFallbackKeys("serverTimeZone")
+ .withDescription(
+ "The session time zone of the database server, for
example: \"Asia/Shanghai\". "
+ + "It controls how the TIMESTAMP column is
converted to string/temporal types. "
+ + "If it is not set,
ZoneId.systemDefault() is used.");
+
Review Comment:
What effect will it have if serverTimezone is configured in
`jdbc:mysql://.../db?serverTimezone=xxx` and `server_time_zone` is also
configured here? Can more adequate test verifications be conducted for time
zone issues? Add some possible scenarios in the documentation to guide users on
how to use it.
cc @corgy-w @davidzollo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
