chl-wxp commented on code in PR #10133:
URL: https://github.com/apache/seatunnel/pull/10133#discussion_r2629183508


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlan.java:
##########
@@ -274,6 +278,18 @@ public synchronized void updateJobState(@NonNull JobStatus 
targetState) {
             log.info(
                     String.format(
                             "%s turned from state %s to %s.", jobFullName, 
current, targetState));
+            if (!targetState.isEndState()

Review Comment:
   > Actually, the `INITIALIZING` and `CREATED` states are not reported by this 
method.
   
   Why? Did I read it wrong? But in the 
org.apache.seatunnel.engine.common.job.JobStatus enumeration, both INITIALIZING 
and CREATED are marked as EndState.NOT_END.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to