corgy-w commented on code in PR #10145:
URL: https://github.com/apache/seatunnel/pull/10145#discussion_r2633483079
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/CommonFunction.java:
##########
@@ -44,6 +46,17 @@ public static SeaTunnelDataType resolveExpressionType(
if (expression instanceof NullValue) {
return null;
}
+ if (expression instanceof ComparisonOperator) {
+ return BasicType.BOOLEAN_TYPE;
+ }
+ if (expression instanceof BinaryExpression) {
+ BinaryExpression binaryExpression = (BinaryExpression) expression;
+ SeaTunnelDataType leftType =
+
resolveExpressionType(binaryExpression.getLeftExpression(), rowType);
+ SeaTunnelDataType rightType =
+
resolveExpressionType(binaryExpression.getRightExpression(), rowType);
+ return unifyCollectionType(leftType, rightType);
+ }
Review Comment:
Is there a corresponding repair test case for this one? Why wasn't this one
taken out together with the other PR from last time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
