chl-wxp commented on code in PR #10207:
URL: https://github.com/apache/seatunnel/pull/10207#discussion_r2634261223
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-sqlserver/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/sqlserver/source/offset/LsnOffset.java:
##########
@@ -29,7 +29,7 @@ public class LsnOffset extends Offset {
private static final long serialVersionUID = 1L;
- public static final LsnOffset INITIAL_OFFSET = valueOf(Lsn.valueOf(new
byte[] {0}).toString());
+ public static final LsnOffset INITIAL_OFFSET = new LsnOffset(null, null,
null);
public static final LsnOffset NO_STOPPING_OFFSET =
valueOf(Lsn.valueOf(new byte[] {Byte.MAX_VALUE}).toString());
Review Comment:
Does the NO_STOPPING_OFFSET constant have similar problems or risks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
