dybyte commented on code in PR #10223:
URL: https://github.com/apache/seatunnel/pull/10223#discussion_r2648341786
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java:
##########
@@ -1112,8 +1142,32 @@ protected void
completeSchemaChangeAfterCheckpoint(CompletedCheckpoint checkpoin
}
}
- public String getCheckpointStateImapKey() {
- return checkpointStateImapKey;
+ /**
+ * Clean only the failed checkpoint(s) without shutting down the
coordinator. This is used for
+ * tolerable checkpoint failures to allow subsequent checkpoints to
continue.
+ */
+ protected void cleanFailedCheckpoint(CheckpointCloseReason closedReason) {
+ synchronized (lock) {
+ LOG.info("start clean failed checkpoint cause {}",
closedReason.message());
+ if (!pendingCheckpoints.isEmpty()) {
+ pendingCheckpoints
+ .values()
+ .forEach(
+ pendingCheckpoint ->
+
pendingCheckpoint.abortCheckpoint(closedReason, null));
+ pendingCheckpoints.clear();
+ }
+ pendingCounter.set(0);
Review Comment:
What happens if there is still a pending checkpoint in progress? Could this
cause any consistency issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
