yzeng1618 commented on PR #10275: URL: https://github.com/apache/seatunnel/pull/10275#issuecomment-3709063679
> This seems duplicate with #10208 . Thanks for the heads-up! I checked #10208. #10208 adds a framework-level re-signal: if a reader re-registers after failover and **NoMoreSplitsEvent was already signaled before**, the engine/flink translation will re-signal it to that reader. This PR (#10275) fixes a different issue in `FakeSourceSplitEnumerator`: it previously called `signalNoMoreSplits()` only when it actually assigned splits. After restore (or late registration), a reader may receive **zero splits**, so it never gets the end-of-input signal and can wait forever (see the added unit test `signalNoMoreSplitsAfterRestoreWhenNoPendingSplits`). So they’re complementary: #10275 ensures FakeSource always produces `signalNoMoreSplits` for all registered readers after discovery (even when no split is assigned), while #10208 ensures previously signaled NoMoreSplits can be re-delivered after failover. Happy to adjust/split if you prefer consolidating on one approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
