yzeng1618 commented on code in PR #10295:
URL: https://github.com/apache/seatunnel/pull/10295#discussion_r2674518087
##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/client/HbaseClient.java:
##########
@@ -377,8 +377,12 @@ public ResultScanner scan(
String[] columnNameSplit = columnName.split(":");
scan.addColumn(Bytes.toBytes(columnNameSplit[0]),
Bytes.toBytes(columnNameSplit[1]));
}
+ String namespace =
+ StringUtils.isBlank(hbaseParameters.getNamespace())
Review Comment:
Thanks for pointing this out. I centralized the fallback in
HbaseParameters#getNamespace() (returns DEFAULT_NAMESPACE when null/blank, also
safe for direct builder usage), so I removed the redundant null/blank checks in
HbaseClient/HbaseSourceSplitEnumerator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
