aksmf1442 opened a new pull request, #10360:
URL: https://github.com/apache/seatunnel/pull/10360
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
This PR addresses the ambiguity and potential parsing errors in the
PARSEDATETIME and TO_DATE functions by introducing
whitelist-based validation for datetime format patterns.
**Problem:**
Currently, these functions use pattern matching (contains("yy"),
contains("mm")) to infer the return type
(LocalDateTime/LocalDate/LocalTime), which leads to:
1. Unclear documentation on which formats are officially supported
2. Unpredictable behavior due to delegating all format validation to
DateTimeFormatter, making it impossible to control or
predict which format patterns will be accepted and how they will behave
**Solution:**
- Introduced ZetaDateTimeFormat enum with predefined, validated format
patterns
- Added strict whitelist validation that rejects unsupported formats with
clear error messages
- Updated documentation to explicitly list all supported formats
**Supported Format Patterns:**
- DateTime: yyyy-MM-dd HH:mm:ss, yyyy-MM-dd HH:mm:ss.SSS,
yyyy-MM-dd'T'HH:mm:ss, yyyy-MM-dd'T'HH:mm:ss.SSS
- Date: yyyy-MM-dd
- Time: HH:mm:ss, HH:mm:ss.SSS
**Related issues:** #10352
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
### Does this PR introduce _any_ user-facing change?
Yes. Users who were using unsupported datetime format patterns (e.g.,
yyyy-M-d, dd/MM/yyyy, HH:mm) will now receive a clear
TransformException with the message:
Unsupported datetime format: '<pattern>'
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
### How was this patch tested?
Unit Tests Added:
**1. ZetaDateTimeFormatTest.java**
- testFromPatternWithAllDateTimeFormats() - Validates all DateTime format
patterns
- testFromPatternWithAllDateFormats() - Validates Date format patterns
- testFromPatternWithAllTimeFormats() - Validates Time format patterns
- testFromPatternWithInvalidFormat() - Ensures invalid patterns return
empty Optional
- testFromPatternIsCaseSensitive() - Verifies case sensitivity
- testAllEnumValuesAreUnique() - Prevents duplicate patterns
**2. DateTimeFunctionsTest.java**
- testParseDateTimeWithAllDateTimeFormats() - Tests all 4 DateTime patterns
- testParseDateTimeWithAllDateFormats() - Tests Date pattern
- testParseDateTimeWithAllTimeFormats() - Tests both Time patterns
- testParseDateTimeWithUnsupportedFormat() - Verifies exception for
unsupported patterns
- testParseDateTimeWithMalformedInput() - Verifies exception for malformed
input
- testToDateWithVariousFormats() - Tests TO_DATE alias function
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
