DanielCarter-stack commented on PR #10372: URL: https://github.com/apache/seatunnel/pull/10372#issuecomment-3772703118
<!-- code-pr-reviewer --> Thanks for the refactoring! • The PR description notes that connector-s3-redshift and connector-hive are not updated, leaving two patterns coexisting in the codebase. This increases inconsistency and may confuse developers about which pattern to follow. • `SourceOptions.java:28` - The new `SourceOptions` base class defines common CDC options (URL, STARTUP_MODE_KEY, STOP_MODE_KEY) but lacks class-level JavaDoc explaining its purpose and how subclasses should extend it. This increases the learning curve for developers implementing CDC connectors. Consider adding a JavaDoc to `SourceOptions` and creating a follow-up issue to complete the migration for the remaining connectors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
