corgy-w commented on code in PR #10367:
URL: https://github.com/apache/seatunnel/pull/10367#discussion_r2712710560
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialect.java:
##########
@@ -79,18 +79,18 @@ public JdbcDialectTypeMapper getJdbcDialectTypeMapper() {
@Override
public Optional<String> getUpsertStatement(
- String database, String tableName, String[] fieldNames, String[]
uniqueKeyFields) {
+ String database, String tableName, String[] fieldNames, String[]
pkNames) {
List<String> nonUniqueKeyFields =
Review Comment:
@dybyte It is caused by historical reasons. The upstream passes pknames, not
uniqueKeyFields. You can check who called the `getUpsertStatement`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
