Best2Two commented on PR #10497: URL: https://github.com/apache/seatunnel/pull/10497#issuecomment-3939159757
Hi @davidzollo, thank you for the detailed feedback again, really appreciate it :) I have addressed all the points as follows: Multi-Table Routing Semantics: Kept the per-table buffering map to ensure correctness in low-parallelism or dynamic routing scenarios. Added a comment in AmazonDynamoDBWriter to clarify this runtime routing logic. Synchronization Scope in flush(): Refactored the flush() method in DynamoDbSinkClient to use a snapshot pattern. The network I/O and retry sleep now execute outside the synchronized block to prevent writer contention. Configurable Retry Policy: Replaced hardcoded values with new optional configuration settings: max_retries, retry_base_delay_ms, and retry_max_delay_ms. Test Fidelity: Refactored AmazonDynamoDBMultiTableSinkTest to remove brittle reflection. Used protected constructors for dependency injection to improve maintainability and better simulate runtime behavior. Please let me know if any further adjustments are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
