zhangshenghang opened a new pull request, #10673:
URL: https://github.com/apache/seatunnel/pull/10673

   ### Purpose of this pull request
   
   This PR improves the parsing of health metrics strings to handle malformed 
tokens gracefully, with enhanced logging for invalid tokens to help diagnose 
issues while avoiding log flooding.
   
   Key changes:
   - **SeaTunnelClient**: Improved `parseHealthMetricsString` to handle 
malformed tokens, keep commas inside values (e.g., "12,34%"), and add 
rate-limited warning logs for invalid tokens
   - **BaseService**: Similar parsing improvements for system monitoring 
metrics with better handling of malformed tokens
   - **SeaTunnelHealthMonitor**: Fixed missing comma separator after "n/a" 
value in `load.systemAverage`
   - Added unit tests for health metrics parsing in both `SeaTunnelClient` and 
`BaseService`
   
   ### Does this PR introduce _any_ user-facing change?
   
   No user-facing behavior change. The health metrics API returns the same 
valid data, but now gracefully handles malformed tokens instead of potentially 
throwing errors or producing incomplete results.
   
   ### How was this patch tested?
   
   - Added unit tests: `SeaTunnelClientHealthMetricsParsingTest` and 
`BaseServiceHealthMetricsParsingTest`
   - Tests cover: normal parsing, malformed tokens handling, comma-in-value 
handling, rate-limited logging, null/empty input handling
   
   ### Check list
   
   * [x] If any new Jar binary package adding in your PR, please add License 
Notice according [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to