knight6236 commented on issue #10669: URL: https://github.com/apache/seatunnel/issues/10669#issuecomment-4162535749
Hi @davidzollo , thank you so much for the thorough review and valuable feedback! It's great to hear that the observations are accurate and the phased approach aligns with the community's needs. I'm definitely interested in starting with Phase 1, and I've already submitted the PR #10678 for explicit URLClassLoader close. The implementation follows exactly what we discussed: - When `cacheMode = false`, call `URLClassLoader.close()` immediately after `recycleClassLoaderFromThread()` when the reference count reaches zero - When `cacheMode = true`, defer the close to `DefaultClassLoaderService.close()` (service shutdown) to preserve the existing caching contract - Also added a JAR URL connection cache disable at startup to prevent stale file handles, and an optional deep clean mode for internal JVM caches (disabled by default, requires `--add-opens` for JDK 9+) The PR is fully backward compatible, and I've verified that existing unit tests continue to pass. Could you please help review the PR when you have a chance? Any feedback is welcome, and I'll adjust it in time. Once Phase 1 is merged and verified stable in production, I'll move forward with Phase 2 (stabilize classloading boundaries) and continue the collaboration. Thanks again for the support! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
