hailin0 commented on code in PR #10657:
URL: https://github.com/apache/seatunnel/pull/10657#discussion_r3027183453
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/options/ConnectorCommonOptions.java:
##########
@@ -73,12 +73,12 @@ public class ConnectorCommonOptions
+ "the current plug-in processes the data
set dataset output by the previous plugin in the configuration file. "
+ "When plugin_input is specified, the
current plug-in is processing the data set corresponding to this parameter.");
- public static Option<String> DATASOURCE_ID =
- Options.key("datasource_id")
Review Comment:
As above
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/metadata/exception/MetaDataProviderException.java:
##########
@@ -15,29 +15,29 @@
* limitations under the License.
*/
-package org.apache.seatunnel.api.datasource.exception;
+package org.apache.seatunnel.api.metadata.exception;
import org.apache.seatunnel.api.common.SeaTunnelAPIErrorCode;
import org.apache.seatunnel.common.exception.SeaTunnelRuntimeException;
-/** A DataSourceProvider-related, runtime exception. */
-public class DataSourceProviderException extends SeaTunnelRuntimeException {
+/** A MetaDataProvider-related, runtime exception. */
+public class MetaDataProviderException extends SeaTunnelRuntimeException {
Review Comment:
MetaData -> Metadata
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/options/table/ColumnOptions.java:
##########
@@ -76,10 +76,10 @@ public interface ColumnOptions {
.noDefaultValue()
.withDescription("SeaTunnel Schema Column Comment");
- Option<String> SCHEMA_URL =
- Options.key("schema_url")
Review Comment:
Doesn't compatibility need to be maintained?
##########
seatunnel-engine/seatunnel-engine-common/src/test/resources/conf/datasource-nested-config.yaml:
##########
@@ -41,7 +41,7 @@ seatunnel:
enabled: false
logs:
scheduled-deletion-enable: false
- datasource:
Review Comment:
As above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
