heye1005 opened a new pull request, #10701: URL: https://github.com/apache/seatunnel/pull/10701
## Purpose Complete the `optionRule()` declarations in `RocketMqSinkFactory` and `RocketMqSourceFactory` by adding missing configuration options that were defined in code but not declared in the option rules, so they are properly exposed in SeaTunnel Web UI. ## Changes ### `RocketMqSinkFactory` - Add `tag` to optional options - Add `format` to optional options - Add `field.delimiter` to optional options - Add `acl.enabled` to optional options - Add conditional rule: when `acl.enabled = true`, `access.key` and `secret.key` are required ### `RocketMqSourceFactory` - Add `field.delimiter` to optional options - Add `acl.enabled` to optional options - Add conditional rule: when `acl.enabled = true`, `access.key` and `secret.key` are required ## Discussion: `field.delimiter` and `format` Currently the RocketMQ connector supports two formats: `json` (default) and `text`. `field.delimiter` is only meaningful when `format = text`. A stricter approach would be to declare it as a conditional: ```java .conditional(RocketMqBaseOptions.FORMAT, SchemaFormat.TEXT, RocketMqBaseOptions.FIELD_DELIMITER) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
