xxzuo commented on code in PR #10690:
URL: https://github.com/apache/seatunnel/pull/10690#discussion_r3028433330
##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/util/MaxcomputeUtil.java:
##########
@@ -47,6 +47,11 @@ public static TableTunnel getTableTunnel(ReadonlyConfig
readonlyConfig) {
if
(StringUtils.isNotEmpty(readonlyConfig.get(MaxcomputeBaseOptions.TUNNEL_ENDPOINT)))
{
tableTunnel.setEndpoint(readonlyConfig.get(MaxcomputeBaseOptions.TUNNEL_ENDPOINT));
}
+ if
(StringUtils.isNotEmpty(readonlyConfig.get(MaxcomputeBaseOptions.TUNNEL_NAME)))
{
+ tableTunnel
+ .getConfig()
+
.setQuotaName(readonlyConfig.get(MaxcomputeBaseOptions.TUNNEL_NAME));
Review Comment:
If the program is deployed in a VPC environment and uses the MaxCompute VPC
endpoint, in most cases, the TUNNEL ENDPOINT will be automatically routed to
the TUNNEL VPC ENDPOINT. Therefore, we do not need to perform empty checks on
the tunnel endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
