davidzollo commented on code in PR #10698:
URL: https://github.com/apache/seatunnel/pull/10698#discussion_r3028747777
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/hive/HiveDialect.java:
##########
@@ -68,4 +68,8 @@ public JdbcConnectionProvider getJdbcConnectionProvider(
JdbcConnectionConfig jdbcConnectionConfig) {
return new HiveJdbcConnectionProvider(jdbcConnectionConfig);
}
+
+ private String modifySQLToLimit1(String sql) {
+ return String.format("SELECT * FROM (%s) s LIMIT 1",
sql.trim().replaceAll(";$", ""));
Review Comment:
Would it be better to use LIMIT 0 (or add the WHERE 1=0 condition)? Besides,
this modification will cause version incompatibility, right? It needs to be
explained in the incompatibility document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
