DanielLeens commented on issue #10870: URL: https://github.com/apache/seatunnel/issues/10870#issuecomment-4468816674
Thanks for volunteering to work on this. One important clarification before you start: the `context is null` stack in this issue is likely not the main failing path by itself. In the current code, `FactoryUtil.createAndPrepareSink(...)` does a fallback probe by calling `sinkFactory.createSink(null)` first, so that message can be noisy and misleading. The more important path in the original report is the target-table / save-mode behavior: - the Milvus sink currently reads `collection` - if that option is absent, it falls back to the upstream table name - with `schema_save_mode = ERROR_WHEN_SCHEMA_NOT_EXIST`, that can then fail later with `The sink table not exist` So if you want to work on this, please focus on reproducing the original configuration path first and then verify which part actually needs fixing: 1. whether the collection option handling should be improved or made more compatible 2. whether the null-context probe should be made safer / less noisy A regression test is definitely welcome, but it would be better not to narrow the fix to the probe-time NPE alone unless you can show that it independently breaks the job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
