DanielLeens commented on PR #10878:
URL: https://github.com/apache/seatunnel/pull/10878#issuecomment-4518061733
Thanks for the update. I pulled the latest head
`5cfdb1337d5753130d20109d3108edd9a5c12fc1` locally as `seatunnel-review-10878`
and re-reviewed the current PR state against `apache/dev`.
The key point on this round is that the delta after Daniel's last approved
head `d98b0790592d6ee34a40015e1240c2c0f9fccb2a` is docs-only:
```text
git diff --name-status d98b0790592d6ee34a40015e1240c2c0f9fccb2a...HEAD
M docs/en/connectors/source/EdgeSocket.md
M docs/zh/connectors/source/EdgeSocket.md
```
# What this PR fixes
- User pain: edge collectors need a lightweight, checkpoint-aware ingress
path into Zeta.
- Fix approach: EdgeSocket source, protocol semantics, queue/backpressure
handling, checkpoint watermarking, and matching tests/docs.
- In one sentence: this is the EdgeSocket ingress MVP.
# Runtime path I rechecked
```text
collector
-> EdgeSocketIngressServer
-> TOKEN auth
-> single-collector connection model
-> queue / backpressure watermark
-> EdgeSocketSourceReader
-> consume queued records
-> checkpoint watermark progression
-> COMMIT polling returns ACK / PENDING / RESEND
```
I specifically rechecked the latest docs against the runtime constraints
that matter most:
- `parallelism = 1`
- single collector model
- TOKEN-only auth
- `QUEUE_FULL`, `RETRY`, `RESEND`, and `REJECTED` semantics
- globally monotonic `batchId`
Those pieces are still aligned with the implementation, and I do not see a
new source-level blocker on the current head.
# Testing coverage and stability
There is no new test-code delta on top of the previously reviewed head, and
I do not see a new test-stability concern introduced by the current docs-only
update.
# Merge conclusion
### Conclusion: can merge
1. Blocking items
- I did not find a blocking issue on the current head.
2. Suggested follow-up items
- None.
Overall, the latest update is a documentation refresh on top of a code path
Daniel had already approved, and the refreshed docs still match the actual
protocol/runtime constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
