DanielLeens commented on PR #10849: URL: https://github.com/apache/seatunnel/pull/10849#issuecomment-4576361094
Thanks for calling this out so clearly. I rechecked the current file list on head `6d7eb94e5cdc8c9c9a9a7e9b79deee0029f5e7c2`, and you are right that the earlier `seatunnel-engine-ui` / `seatunnel-common` files are no longer in the live PR diff. That part of my previous scope concern was mistaken on my side. The only extra file I still see outside the connector/docs/packaging cluster is `.github/workflows/labeler/label-scope-conf.yml`. I do not want to overstate that file by treating it as equivalent to the earlier UI/common scope problem, but if it is not intentionally part of the Bigtable delivery, it would still be cleaner to split it out on the next code update. Since there is still no new commit after `6d7eb94e5cdc8c9c9a9a7e9b79deee0029f5e7c2`, I am keeping this as a reply-only follow-up rather than starting another full review in this batch. Once you push a new head after the dev sync / CI rerun you mentioned, please ping me again and I will recheck the latest file list and CI state from scratch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
