nzw921rx commented on PR #10800:
URL: https://github.com/apache/seatunnel/pull/10800#issuecomment-4601431912
#### 1. Backend: Flush signal metrics aggregation
- Add 7 new metric names in `MetricNames`: `FlushSignalQPS`,
`FlushSignalSinkQPS`, `FlushSignalTotal`, `FlushSignalQueueSuccessTotal`,
`FlushSignalQueueFailureTotal`, `FlushSignalSinkSuccessTotal`,
`FlushSignalSinkFailureTotal`
- `BaseService.getJobMetrics()` aggregates per-vertex flush metrics into
`*PerVertex` maps (e.g. `FlushSignalQPSPerVertex: {"Source[0]": "29.32"}`)
- Add fallback logic in `groupMetricByVertex`: when `TASK_NAME` tag
extraction fails, uses `JobDAGInfo` vertex identifiers to correctly group
metrics
#### 2. UI: Job detail overview table — add "Flush Signal QPS" column
- New column in the overview table showing per-vertex flush signal QPS
- Source rows display `FlushSignalQPSPerVertex` values
- Sink rows display `FlushSignalSinkQPSPerVertex` values
<img width="2534" height="1106" alt="fs_table"
src="https://github.com/user-attachments/assets/496a09b5-c4c9-4080-b638-b5da284620eb";
/>
#### 3. UI: Job vertex detail drawer — add flush signal metrics
- **Source vertex detail** shows:
- `FlushSignalTotal` — total flush signals sent
- `FlushSignalQueueSuccess` — successfully queued
- `FlushSignalQueueFailure` — queue failures
<img width="2521" height="1234" alt="fs_source"
src="https://github.com/user-attachments/assets/9f2224ff-2443-4c56-9dda-259a97fbf9df";
/>
- **Sink vertex detail** shows:
- `FlushSignalSinkSuccess` — successfully processed
- `FlushSignalSinkFailure` — processing failures
<img width="2550" height="1256" alt="fs_sink"
src="https://github.com/user-attachments/assets/3cf3f703-b126-4393-af79-cbbd9f19c989";
/>
#### 4. UI: Fix metric display issues
- Fix NaN/zero display when `tablePaths` format doesn't match backend metric
keys (e.g. `tablePaths=["fake"]` vs metric key `"Source[0].fake"`)
- Implement `resolveMetricValue` with 4-level key matching fallback:
1. Exact prefixed key: `${vertexId}.${path}`
2. Exact plain path: `${path}`
3. Vertex-aware suffix match: `endsWith(path) && includes(vertexId)`
4. Generic suffix match: `endsWith(path)`
- Add `formatNumber`: integers display as-is, decimals rounded to 2 decimal
places
- Add `MetricMapKey` utility type for type-safe metric key access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
