DanielLeens commented on PR #10964: URL: https://github.com/apache/seatunnel/pull/10964#issuecomment-4741127503
Thanks, this narrower MVP statement helps. Framing this explicitly as "source-side document routing for Markdown only" is the right way to avoid over-claiming a generic engine-level hash-routing API in this PR. That also addresses @nzw921rx's scope question from my side: this can fit a Phase 1 slice as long as the PR description and the related design issues clearly say the reusable cross-connector contract is follow-up work, not something this PR is already trying to finalize. At the same time, there is still no new commit after Daniel's June 13 full review on `1227aa36`, so I am not turning this discussion update into another full source review on the same code version. My current Daniel state stays reply-only on the unchanged head: if the PR framing is updated to match this narrowed MVP boundary, that improves the scope clarity; if the branch itself changes, I am happy to re-review the latest head from scratch again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
