DanielLeens commented on issue #11036: URL: https://github.com/apache/seatunnel/issues/11036#issuecomment-4814463304
Thanks for calling out the terminal semantics explicitly. That is exactly the right boundary to make clear before implementation starts. For the first PR, I would keep the contract strict and easy to review: 1. `snapshot-only` is a bounded job mode 2. once all snapshot splits are finished, the job should complete successfully instead of switching into incremental/binlog reading 3. restore behavior should stay inside the same contract: resume remaining snapshot work if needed, but never transition into binlog consumption for this mode If the current source path already supports checkpoints during snapshot, that is fine to preserve. The important part is that completion and recovery semantics stay deterministic and are documented clearly in both code and docs. A focused test that proves no binlog reader is started after snapshot completion would be especially valuable here. That would make the feature boundary much easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
