DanielCarter-stack commented on PR #11373:
URL: https://github.com/apache/seatunnel/pull/11373#issuecomment-4913190972
Updated the Feishu docs branch to address the review feedback:
- Removed the claim that the Feishu URL supports `${database_name}`,
`${schema_name}`, and `${table_name}` replacement, and replaced the multi-table
URL placeholder example with a `multi_table_sink_replica` example using a fixed
webhook URL.
- Added a note that query parameters should only be non-sensitive, and that
authentication material should prefer headers when the gateway supports it
because the full URL may appear in logs or job metadata.
- Replaced `xxxx` webhook tokens with an explicit `<your-hook-token>`
placeholder in both EN and ZH examples.
- Re-aligned the option tables in both files.
I kept `batch_size` default as `1` after checking
`HttpSinkOptions.BATCH_SIZE` and `HttpParameter`, which both define the sink
default as `1` on the current branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
