davidzollo commented on PR #10320: URL: https://github.com/apache/seatunnel/pull/10320#issuecomment-4915239665
I pushed a follow-up commit to the PR branch to close the `commit_on_checkpoint` gap on the actual Kafka consumer path. What changed: - extracted the consumer-property assembly into a testable helper - kept `enable.auto.commit=false` when `commit_on_checkpoint=true` - added `KafkaPartitionSplitReaderTest` to cover both commit modes Local verification: - `./mvnw -pl seatunnel-connectors-v2/connector-kafka -Dtest=KafkaSourceConfigTest,KafkaPartitionSplitReaderTest -DfailIfNoTests=false -Dspotless.check.skip=true test` I also checked WhaleTunnel `2.6-test` and found the same logic inversion there, so I filed a tracking issue on that side as well (`ST-3598`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
