zhaoysg commented on PR #11113: URL: https://github.com/apache/seatunnel/pull/11113#issuecomment-4924000715
Thanks for the careful re-review. I pushed `9811e7daf0dc` to address the two blocking items: 1. For the protected `TiDBSourceReader.flushRows(long)` signature, I restored the original `protected void flushRows(long)` method for compatibility and moved the new safe-resolved-ts return path into a private helper `flushRowsAndGetSafeResolvedTs(long)`. The runtime path now uses the private helper, while downstream subclasses compiled against the old protected method are not forced through a signature change. 2. For the custom Java deserialization concern, I removed `readObject(ObjectInputStream)` from `TiDBSourceCheckpointState`. Legacy/current pending split normalization is now done through the normal getter/setter/constructor path, and the list copy path now validates each element is a `TiDBSourceSplit` instead of relying on an unchecked list cast. For the doc/config note: the PR already includes the TiDB CDC doc updates for the diagnostic option in both `docs/en` and `docs/zh`. Verified locally: ```bash ./mvnw.cmd -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb spotless:apply ./mvnw.cmd -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb -DskipIT=true -Dtest=TiDBSourceReaderTest,TiDBSourceSplitEnumeratorTest test ``` Result: `Tests run: 4, Failures: 0, Errors: 0, Skipped: 0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
