Isha2790 opened a new pull request, #11398:
URL: https://github.com/apache/seatunnel/pull/11398
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
This pull request introduces comprehensive defensive null-checks in
`JobDAGInfo.java` inside the `toJsonObject()` method to prevent potential
`NullPointerException` (NPE) runtime failures during internal job configuration
serialization or cluster state reporting via the REST API.
Specifically, this PR ensures that:
- Deep nested paths (e.g., `vertexInfo.getType().getType()`) check for
intermediary null references.
- Potential null wrappers like `jobId`, `vertexId`, and list elements are
safely handled with clean ternary operators rather than crashing the thread
with unboxing or direct method access failures.
- Optional parameters like `envOptions` fallback safely to an empty JSON
structure when absent.
### Does this PR introduce _any_ user-facing change?
No. This is a purely internal stabilization fix that hardens runtime
execution safety. It does not alter behavior or configuration formats for users.
### How was this patch tested?
- This changes basic string-formatting serialization utility methods inside
the `seatunnel-engine-core` sub-module.
- The module has been compiled and run locally to verify code correctness.
- The codebase formatting guidelines have been strictly preserved by
executing `mvn spotless:apply` locally before final commit.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
