Tlinian commented on PR #11397: URL: https://github.com/apache/seatunnel/pull/11397#issuecomment-4964530492
> @Tlinian Thank you very much for supplementing the data types supported by YashanDB in the future. I think we need to add an E2E that can cover all the types currently supported. Thank you again for your contribution🚀 @nzw921rx Thanks for your suggestion! Currently, the vector-supported version of YashanDB has not been officially released to the public, which means we cannot upgrade the database version in the CI environment to run and verify these vector E2E tests at the moment. To move forward, how would you prefer we handle this? - We can write the E2E test cases now but mark them to be skipped in CI for the time being. - We can add unit tests with mocked data first to cover the logic, and implement the E2E tests later once the vector version is officially released and available in CI. Let me know what you think! Thank you again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
