DanielLeens commented on PR #11380:
URL: https://github.com/apache/seatunnel/pull/11380#issuecomment-4968429129
Rechecked the current head `751dec8ca244` against the latest `dev` after the
CI / merge-gate fact changed.
## Runtime path rechecked
```text
snapshot-only
-> PostgresSourceOptions.STARTUP_MODE
-> IncrementalSource.getBoundedness() returns BOUNDED
-> SnapshotOnlySplitAssigner emits snapshot splits only
-> reader receives a SnapshotSplit
-> PostgresSourceConfigFactory.create()
-> does not map SeaTunnel snapshot-only to Debezium
snapshot.mode=initial_only
-> Debezium defaults to snapshot.mode=initial
-> PostgresSourceFetchTaskContext.configure()
-> InitialSnapshotter.shouldStream() returns true
-> creates a replication connection
-> creates the logical replication slot when it does not exist
-> snapshot finishes and the enumerator signals NoMoreSplits
-> bounded job exits
-> slot.drop.on.stop defaults to false
-> the slot remains without a WAL consumer advancing confirmed_flush_lsn
committed-offset
-> validates that slot.name is explicitly configured
-> LsnOffsetFactory.committedOffset()
-> reads pg_replication_slots.confirmed_flush_lsn
-> builds the Debezium PostgreSQL offset
-> IncrementalSplitAssigner creates the incremental split
-> PostgresSourceFetchTaskContext rebuilds PostgresOffsetContext
-> PostgresWalFetchTask
-> Debezium PostgresStreamingChangeEventSource
-> starts from the committed WAL position
-> locates the transaction boundary
-> reads WAL events
-> advances the committed offset after checkpoint completion
```
## Merge conclusion
### Conclusion: still needs fixes before merge
1. Blocking items
- The source-side blockers from my previous Daniel review still stand on
this unchanged head.
- Separately, this branch is behind upstream (`compare status: diverged`,
`ahead_by=3`, `behind_by=20`), and the current failing gate is `FAILURE gate:
Build`: https://github.com/apache/seatunnel/runs/86998185983
2. Lowest-cost next step
- Please sync with the latest `dev` and rerun the failing gate first so we
can separate baseline CI noise from the remaining code-side fixes.
- After that, if the same source blocker is still unresolved, I would still
keep this PR out of merge-ready state from Daniel's side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
