DanielLeens commented on PR #11395:
URL: https://github.com/apache/seatunnel/pull/11395#issuecomment-4968430817
Rechecked the same unchanged head `a1f709208e59` after the CI / merge-gate
fact changed.
## Runtime path rechecked
```text
record/heartbeat emitted
-> update currentConsumedPosition
snapshotState(checkpointId)
-> retain checkpoint candidate for that id
notifyCheckpointComplete(checkpointId)
-> promote the candidate to lastCheckpointedPosition
restore/addSplits
-> record restoredFromPosition separately
```
## Merge conclusion
### Conclusion: still needs fixes before merge
1. Blocking items
- The source-side blockers from my previous Daniel review still stand on
this unchanged head.
2. Current gate update
- The CI / merge-gate fact I referenced earlier has changed. The current
status is `PENDING gate: Build`:
https://github.com/apache/seatunnel/runs/86985967620
So my technical conclusion is unchanged on merge readiness: this PR still
needs the earlier code-side fixes first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
