nielifeng commented on PR #11423: URL: https://github.com/apache/seatunnel/pull/11423#issuecomment-4987502040
Thanks for the thorough review, @SEZ9. All five points were addressed in `eb429f411`, which was pushed after your review of `98407648d`. Details below: **Issue 1 (High) — `schema_evolution_enabled` removed from sink docs** Restored the table row and the full `### schema_evolution_enabled [boolean]` section (format restriction, partition constraint, and the fail-fast `AlterTableEvent` error text) in both `docs/en/connectors/sink/S3File.md` and `docs/zh/connectors/sink/S3File.md`. **Issue 2 (High) — `enable_file_split`/`file_split_size` removed from source docs** Restored both table rows and their sections in `docs/en/connectors/source/S3File.md` and `docs/zh/connectors/source/S3File.md`. **Issue 3 (Medium) — static-key exposure surface** Extended the fallback guidance to note that rendered `access_key`/`secret_key` values can be exposed through the Zeta REST job-config/info endpoints and verbose logs, and to recommend restricting REST API access and keeping connector logging at INFO or above. Mirrored in the zh docs. **Issue 4 (Medium) — legacy `connector-v2`/`transform-v2` links** Reverted to the current `connectors/source`, `connectors/sink`, and `transforms` paths. No legacy paths remain in any of the four files. **Issue 5 (Medium) — troubleshooting error text** The troubleshooting bullet now quotes the enum-parse fragment `Could not parse value for enum ... S3aAwsCredentialsProvider` alongside `Factory initialize failed`, and lists the two expected values so users can grep from their stack trace. The scope is back to credential-provider clarification only. Could you take another look when you have a moment? Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
