DanielLeens commented on PR #10808: URL: https://github.com/apache/seatunnel/pull/10808#issuecomment-5082849826
Thanks @nzw921rx for the detailed review. The six blockers and the additional in-scope items from review `4779559625` have now been addressed on the current head. - `e794178716`: fixes `EventServiceTest` by providing a confirmed non-lite coordinator member, so the retry path reaches the invocation builder. - `890816d3a4`: makes connector-jar storage/deletion role-independent through the server-level connector package client; moves coordinator lookup/invocation inside the task-status retry and periodic-metrics exception boundaries; tracks synchronous split-send failures; serializes split enqueue with the checkpoint snapshot monitor; and aligns `ClusterMetricExports`, `OverviewService`, and the member-list command with confirmed active-coordinator semantics. Focused regression tests were added for these paths. - `a7210249e2`: preserves the shared-jar tombstone when remote cleanup fails so cleanup can be retried, and fixes the test compilation/import follow-ups. - `e16b66affc`: addresses the two current-head internal CI failures without weakening assertions: the repeated FAILED-state scenario reuses its existing restore timeout, and the overview E2E waits for the second worker registration before running the original endpoint assertions once. The current head is `e16b66affc504a68192c7c923668d5e0631cf679`. A fresh fork workflow is running at https://github.com/davidzollo/seatunnel/actions/runs/30195946143. Could you please re-review the updated head when convenient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
