davidzollo commented on PR #10958: URL: https://github.com/apache/seatunnel/pull/10958#issuecomment-5133464117
Updated the PR to address the latest close-path review blocker. What changed: - `ArrowToSeatunnelRowReader.close()` now always closes `rootAllocator` from `finally`, even when `arrowStreamReader.close()` throws `IOException`. - The reader close failure is still propagated, and allocator close failures are preserved as suppressed exceptions when both closes fail. - Added focused connector-common regression coverage for both the successful close path and the failing `ArrowStreamReader.close()` path, verifying reader-before-allocator order and unconditional allocator cleanup. Validation performed locally under the Apache SeaTunnel local-validation constraint: - `./mvnw -pl seatunnel-connectors-v2/connector-common spotless:apply spotless:check -DskipTests -DskipIT=true -Dmaven.gitcommitid.skip=true` I did not run local compile/tests/package/E2E; the current GitHub CI on the new head remains the functional gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
