li3zhi4 commented on PR #11618: URL: https://github.com/apache/seatunnel/pull/11618#issuecomment-5157328038
Thanks for the thorough review, @DanielLeens. I have addressed all three blockers: **Blocker 1 (timestamp + specific combination):** `MySqlBinlogFetchTask.execute()` now routes `startup.mode=timestamp` + `stop.mode=specific` into `BoundedMySqlStreamingChangeEventSource`, which accepts an optional timestamp filter. `handleEvent()` skips events before the target timestamp and still checks the stop offset in the `finally` block, so the job terminates at the configured binlog offset instead of running forever. **Blocker 2 (Oracle regression):** Reverted the Oracle/SqlServer option-rule changes from this PR (`[Revert][Connector-CDC] Restore Oracle/SqlServer option rules to upstream state`). Oracle `STARTUP_MODE` is back to `INITIAL/LATEST/TIMESTAMP` with the upstream description — the diff for both files is now empty against `dev`. **Blocker 3 (Code style):** Ran `spotless:apply` on `BinlogOffsetTest.java`; `spotless:check` now passes locally for the module. Also verified locally: `mvn install -pl connector-cdc/connector-cdc-mysql -am -DskipTests` → BUILD SUCCESS, and `BinlogOffsetTest` 9/9 tests pass. Non-blocking suggestions (docs example, log dedup) I'll keep as follow-ups to keep this PR single-purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
