hawk9821 commented on PR #9993: URL: https://github.com/apache/seatunnel/pull/9993#issuecomment-5186609833
> Thanks for the update. I rechecked the latest head `c70b99f1d484` again. > > The important change here is that the current head actually closes the earlier packaging blocker Daniel had on the starter exclude coordinate, and I do not see a new source-side blocker left on top of that latest head. > > ## Runtime path I rechecked > ``` > Maven dependency resolution > -> root pom / module pom consume external seatunnel-shade artifacts > > starter packaging > -> maven-shade-plugin excludes the real shade coordinates > > dist / docs / E2E > -> users and tests consume the externalized shade artifact contract > ``` > > ## Current finding > ### Issue 1: the Build is green now, but the PR is still merge-conflicted with `dev` > * mergeStateStatus: `DIRTY` > * mergeable_state: `dirty` > * compare status: `diverged` > * behind by: `15` > > So the remaining blocker here is not a reopened source issue from Daniel's side. It is that the current head is not the final mergeable code shape yet because GitHub still reports real merge conflicts against the latest `dev`. > > Please sync with the latest `dev` and resolve the conflicts first. After that, the final gate is just the conflict-resolved exact head and its Build signal. > > ## Merge conclusion > ### Conclusion: can merge after fixes > 1. Blocking items > > * Sync the latest `dev` and resolve the merge conflicts first. > > 2. Non-blocking suggestions > > * No new source-side change is required from Daniel in this round. > > Rechecked the latest head: the source-level blockers from my earlier rounds are cleared for me now. If GitHub still shows historical `changes requested`, please treat that as review-summary residue rather than a current reopened blocker from this exact head. > Thanks for the update. I rechecked the latest head `c70b99f1d484` again. > > The important change here is that the current head actually closes the earlier packaging blocker Daniel had on the starter exclude coordinate, and I do not see a new source-side blocker left on top of that latest head. > > ## Runtime path I rechecked > ``` > Maven dependency resolution > -> root pom / module pom consume external seatunnel-shade artifacts > > starter packaging > -> maven-shade-plugin excludes the real shade coordinates > > dist / docs / E2E > -> users and tests consume the externalized shade artifact contract > ``` > > ## Current finding > ### Issue 1: the Build is green now, but the PR is still merge-conflicted with `dev` > * mergeStateStatus: `DIRTY` > * mergeable_state: `dirty` > * compare status: `diverged` > * behind by: `15` > > So the remaining blocker here is not a reopened source issue from Daniel's side. It is that the current head is not the final mergeable code shape yet because GitHub still reports real merge conflicts against the latest `dev`. > > Please sync with the latest `dev` and resolve the conflicts first. After that, the final gate is just the conflict-resolved exact head and its Build signal. > > ## Merge conclusion > ### Conclusion: can merge after fixes > 1. Blocking items > > * Sync the latest `dev` and resolve the merge conflicts first. > > 2. Non-blocking suggestions > > * No new source-side change is required from Daniel in this round. > > Rechecked the latest head: the source-level blockers from my earlier rounds are cleared for me now. If GitHub still shows historical `changes requested`, please treat that as review-summary residue rather than a current reopened blocker from this exact head. Git rebase has been executed, waiting for CI to pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
