SEZ9 commented on issue #11620: URL: https://github.com/apache/seatunnel/issues/11620#issuecomment-5188386584
Confirmed mismatch on dev: PulsarBaseOptions.FORMAT description and PulsarSourceFactory OptionRule bind field_delimiter for format=text, but validateFormat() only allows JSON, CANAL_JSON, AVRO and createDeserialization() has no TEXT branch. Either the source should implement text deserialization or the contract/docs should drop text. Preferred fix seems to be adding TEXT support: seatunnel-format-text is already a dependency of connector-pulsar, so adding a TEXT branch using TextDeserializationSchema (honoring field_delimiter) plus updating validateFormat() should align runtime with the declared contract. A contribution with an e2e/unit test would be welcome. If maintainers decide text should not be supported on the source side, please also remove field_delimiter binding from PulsarSourceFactory's OptionRule and update the Pulsar source docs to avoid misleading users. <!-- streview-comment:51 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
