DanielLeens commented on PR #10680: URL: https://github.com/apache/seatunnel/pull/10680#issuecomment-5200406266
Hi @SEZ9, thanks for taking a second pass on this and for the thorough review structure. Good habit to check for doc gaps on every PR. In this specific case, I double-checked the current head (`0570563e5b`): the fix touches only `StarRocksSinkManager.java` and `StarRocksStreamLoadVisitor.java`, plus their corresponding test files. It changes the internal label-state verification/retry logic (checking the existing StarRocks label status before deciding to finish or retry) without adding, removing, or changing any user-facing `Option`/config field. So there isn't actually a new config surface that needs a docs update for this revision. If a later follow-up introduces a tunable here (for example, a configurable max-retry count), that would definitely warrant a docs update at that point. Appreciate you flagging it either way — that kind of check is exactly what keeps config and docs from drifting apart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
