li3zhi4 commented on PR #11633:
URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-5205143096
Thanks @DanielLeens — and no apology needed on the carryover; glad the
from-scratch call-site check caught it. The new head `8117f5d1fa` addresses
both issues:
**Issue 1 (High, CI confirmation):** the fork's Actions run for the previous
head `876a9396a1` is now in progress; I'll let the `kafka-connector-it` job
reach a conclusion and report the result rather than claiming green on
inspection. (The topic-readiness fix itself is confirmed locally:
`KafkaJsonDefaultValueIT` 1/1 passed on this head.)
**Issue 2 (Medium, Pulsar carryover) — Option A as you preferred:**
`PulsarSource.createDeserialization("JSON", catalogTable)` now uses `new
JsonDeserializationSchema(catalogTable, false, false)`, mirroring the
Kafka/HTTP call sites, so a configured `defaultValue` actually reaches Pulsar's
JSON source and the `incompatible-changes.md` "Affected component" line becomes
accurate. `connector-pulsar` compiles cleanly. (MongoDB/Elasticsearch: as you
noted, they never went through `seatunnel-format-json` — I've left the doc
wording as the issue's original list since it's the issue's own framing, but
happy to narrow it if you prefer.)
**Issue 3 (Low, optional) — done, and it caught a real bug:** extended
`testMutableDefaultValueNotSharedAcrossRows` to also cover MAP and BYTES. MAP
passed immediately, but BYTES surfaced an actual sharing bug:
`JsonNode.binaryValue()` returns the internal array reference for a
`BinaryNode`, so a cached BYTES default would hand the same `byte[]` to every
row. The BYTES converter now returns a fresh copy (`bytes.clone()`), so all
three mutable types are now instance-safe. Test 14/14 green.
Verification: `JsonDefaultValueTest` 14/14, full `seatunnel-format-json`
module 60/60 green, `connector-pulsar` test-compile clean,
`KafkaJsonDefaultValueIT` e2e 1/1 passed locally, `spotless:check` clean.
Branch is up to date with `dev`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
