SEZ9 commented on PR #11198:
URL: https://github.com/apache/seatunnel/pull/11198#issuecomment-5230722222
Thanks @srijan-singh — the descoped commit is exactly what I asked for. With
the `backend.yml` changes reverted and the branch limited to the Couchbase
connector, this is back in a reviewable state, and I'll do the full re-review
of the latest head from scratch as promised.
A few things on the current status:
1. **Shard ordering fix** — glad the analysis held up and moving the
Couchbase module in the shard ordering resolved the `all-connectors-it-3`
timeout on this branch. That's a scoped, connector-adjacent change, so it's
fine to keep here.
2. **#11636** — I'll leave detailed feedback on that PR directly. My earlier
note still stands: the `-DargLine` heap setting needs to be wired through the
root Surefire/Failsafe config to actually take effect, so please don't treat it
as a guaranteed fix until that's addressed there.
3. **Merge approval** — correct that final approval/merge needs a committer
with write access; @davidzollo has already chimed in, so once my re-review
passes and CI is green on this head, we should be in good shape.
Concrete asks before merge:
- Please sync with the latest `dev` and rerun CI so we have a clean, current
run on the final head (and confirm there's no residual `backend.yml` diff in
the branch).
- If the shared CI flakiness (`ryuk` pull failure / `DatabendCDCSinkIT`)
reappears, just flag it — those are tracked separately in #11624 and won't be
held against this PR.
Also, your last comment ("@DanielLeens there's a…") looks like it got cut
off — could you repost the full message so I don't miss anything?
Thanks for the persistence on this one — it's genuinely close.
<!-- streview-comment:111 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
