goutamadwant commented on PR #11538: URL: https://github.com/apache/seatunnel/pull/11538#issuecomment-5234151809
@SEZ9 @DanielLeens I checked the four cleanup points against the latest head The English usage section already lists sample mode and both sample options and there is only one Common.setDeployMode call I fixed the two remaining areas. Sample option validation now runs through the CommandLineUtils parse callback so invalid combinations use the normal message usage and exit code path. It also runs before Common.setDeployMode so rejected commands do not modify global state Added Javadocs for isEnabled getLimit and isPrintData and added regression coverage for the CLI validation path The branch is synced with current dev. ClientCommandArgsTest and SeaTunnelClientOOMTest pass with 24 tests on JDK 11 Could you please recheck the latest head? thanjks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
