DanielLeens commented on PR #10959: URL: https://github.com/apache/seatunnel/pull/10959#issuecomment-5237307746
Thanks, @SEZ9 — appreciate you double-checking and confirming both points. Agreed all around: the return-type change on `DamengCreateTableSqlBuilder.build()` is internal-only (single in-module caller, updated in the same diff, no SPI/documented extension point), and #10934 already carries the equivalent fix plus the comment-escaping this PR was still missing, so there's no benefit to carrying two implementations of the same code path. @happybrant — thanks again for the original report and for pushing on this; the Dameng auto-create-table issue you surfaced is genuinely fixed on dev now because of your work, even though #10934 landed first. Whenever you have a moment, go ahead and close this one as superseded by #10934 — or a committer can close it on your behalf if that's easier. Either way, no further changes needed from you here, and we'd be glad to see more contributions from you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
