DanielLeens commented on PR #11193: URL: https://github.com/apache/seatunnel/pull/11193#issuecomment-5240168496
I took a fresh look at this PR to review it, and found that the current branch (`dev-kafka-visible-offset-fix-20260626`, head `1bbc14b24d`) now has a zero net diff against `dev` — `git diff dev...HEAD` is empty for this branch. The original commit here (`91cd5f8fa1`, "Count visible Kafka records in exactly-once IT") made `KafkaIT`'s exactly-once consumer-side counting logic track distinct visible offsets instead of assuming monotonic/contiguous ones, so transaction markers that advance the offset without emitting a visible record don't throw off the count. That exact change is already present on `dev` today, merged via #11205 (commit `7be1b0e464`, "Stabilize Kafka exactly-once record reads"). This branch's own subsequent "sync with dev" commits pulled in that already-merged version of the file, so the branch converged back to identical content with nothing left to contribute. Since there's no remaining diff, there's nothing for me to review here. I'd suggest closing this one as superseded by #11205 — happy to take another look if a new commit adds something beyond what's already on `dev`. Thanks for the contribution either way! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
