DanielLeens commented on PR #11728:
URL: https://github.com/apache/seatunnel/pull/11728#issuecomment-5242231265
Thanks @zhangshenghang for the review.
I want to flag that this approval comes in after my own last pass
(CHANGES_REQUESTED, still on the current head `cb9e2394a1` — no new commit has
landed since either of our reviews), which left 3 High-severity blockers open:
- Issue 1: leftover contradictory sentence in
`docs/zh/connectors/source/MySQL-CDC.md:506` that still tells readers to only
use the no-primary-key mode for append-only workloads, directly under an
example that now sets `exactly_once = true` with a configured key.
- Issue 2: `docs/en/connectors/sink/Fluss.md` uses `${schema_name}` where
`${database_name}` is required — for a Fluss-to-Fluss topology the upstream
identifier's `schemaName` is always null, so this silently collapses every
source database into one literal target database with no error.
- Issue 3: `docs/en/connectors/sink/Feishu.md`'s new rich-text example calls
`named_struct(...)`, which doesn't exist in Zeta's SQL transform and will throw
`Unsupported function: named_struct` at runtime.
None of those have a fix-up commit yet, so from my side this isn't ready to
merge as-is. (Issue 4, the Milvus streaming-terminology note, is non-blocking.)
Happy to take another quick pass as soon as a follow-up commit addresses 1-3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
