PDGGK commented on PR #11750: URL: https://github.com/apache/seatunnel/pull/11750#issuecomment-5296398166
Status check, since this has been quiet for a few days: CI is green (3/3) and review is settled — @DanielLeens reviewed it, the suppressed-exception gap he raised was fixed in 477b2d0, and his closing note was that it's down to a committer from here. The change itself is small: `Neo4jSinkWriter.close()` and `Neo4jSourceReader.close()` released the `Session` and then the `Driver` as consecutive unguarded statements, so a throw from the session close leaked the driver. Both now close the driver regardless and keep the first failure, attaching the second as suppressed rather than replacing it. @davidzollo would you have a moment to take a look? No urgency, just flagging that it's ready rather than waiting on anything from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
