SEZ9 commented on PR #10306: URL: https://github.com/apache/seatunnel/pull/10306#issuecomment-5316846593
Thanks everyone for the follow-ups. The outstanding items from @DanielLeens's review are still unresolved: Issue 1 (the compile break) and Issue 2 (missing tests). I don't see evidence in the thread or the diff that either has been addressed yet, so this remains in a changes-requested state from my perspective. Could you please: 1. Fix the compile break and push the change so we can verify it in the diff. 2. Add the missing tests, or explain why they aren't needed. Once those are in place with a passing build, I'm happy to take another look. <!-- streview-comment:165 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
