DanielLeens commented on PR #11174: URL: https://github.com/apache/seatunnel/pull/11174#issuecomment-5322422836
Hi @SEZ9, thanks for pushing this along. Quick status from my side, checked against the current head (`a17bc444f2`): **CI is not green yet**, and it's failing for the exact reason I flagged in my changes-requested review today: `Run / all-connectors-it-3 (8, ubuntu-latest)` still errors on `FakeSpark41IT` with ``` org.junit.platform.commons.PreconditionViolationException: None of the supporting TestTemplateInvocationContextProviders ... provided a non-empty stream ``` This isn't the Windows Hazelcast flake (also present in this run, unrelated) — it's `FakeSpark41IT` being collected outside the dedicated `spark-4-1-it` lane, where `RUN_SPARK_41_CONTAINER` isn't set, so `@DisabledOnContainer` ends up disabling every container and the test errors instead of skipping. Deterministic, not upstream drift. **What's addressed vs. outstanding from my review:** - Addressed: the docs/transform-scope contract mismatch (source/sink-only scope now documented in en/zh), the quick-start split between Spark 2.4/3.3 (`FieldMapper`) and Spark 4.1 (transform-free), and the dev-sync merge itself is clean (same 83-file logical diff, `pom.xml` conflict resolution is purely additive). - Still outstanding (blocking): Issue 1 above — `FakeSpark41IT` needs to skip rather than error when `RUN_SPARK_41_CONTAINER` isn't set, e.g. `@EnabledIfEnvironmentVariable(named = "RUN_SPARK_41_CONTAINER", matches = "true")` on the class, or an equivalent Maven-level exclusion so it's only ever collected by the dedicated `spark-4-1-it` job. - Non-blocking (open, low severity): `SeaTunnelBatchWrite` Javadoc/`useCommitCoordinator()` mismatch, and `SparkEngineTypeResolver` silently defaulting to `SPARK3` on a manifest read failure without logging. @shangeyao once Issue 1 is fixed, please push and I'll take another pass — happy to re-review quickly once that's in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
