DanielLeens commented on PR #11724: URL: https://github.com/apache/seatunnel/pull/11724#issuecomment-5337551808
@SEPURI-SAI-KRISHNA the Javadoc-scoping reasoning on Issue 2 makes sense — documenting the range the operands stay within rather than claiming a bound they don't actually enforce is the right call, and it matches the root cause of the original blocker (declared type and emitted value being assumed to agree with nothing enforcing it). Agreed on keeping the near-ceiling/`MathContext` fix as a tracked follow-up rather than folding it in here. On the CI: I pulled the fork's run (`SEPURI-SAI-KRISHNA/seatunnel` run `32101324858`, head `69ccf7fe00`) directly rather than trusting the Apache-side pointer. `unit-test (11, windows-latest)` has since completed with `conclusion: success` (finished 18:20 UTC on 08-18) — the rerun you asked for already happened and is green, so that leg is clear. The overall run was still finishing as of this check (`rocketmq-connector-it (8, ubuntu-latest)` still `in_progress`), which is why the Apache-side `Build` check is still showing a stale `failure` — it should refresh once the run completes. I don't have rerun or merge permissions myself, so I can't trigger anything further here, but the signal you were chasing is already resolved. Agreed on the fail-fast matrix follow-up being worth its own infra issue rather than widening either PR — thanks for pinning the exact `backend.yml` lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
