davidzollo commented on PR #11721: URL: https://github.com/apache/seatunnel/pull/11721#issuecomment-5342823871
Confirmed independently against the live API state, not just taking the description at face value: - Head: `7cfabc8c` - Checks on this head: `Build`, `labeler`, `Notify test workflow` — all `SUCCESS` - `davidzollo`'s `2026-08-16T10:39:06Z` review (`+1 if CI passes. LGTM`) shows `state: DISMISSED` - My own review at `7cfabc8` (`2026-08-18T10:37:39Z`) is the current `APPROVED` review on the PR - `reviewDecision: REVIEW_REQUIRED`, `mergeStateStatus: BLOCKED`, `mergeable: MERGEABLE` So yes — the dismissal is real, not a stale read. It lines up with the merge-commit push you made (the `upstream/dev` sync needed because `dev` had independently touched `MultiTableSinkWriter.java` via #10306): GitHub's dismiss-stale-reviews branch protection rule fires automatically on any push to the PR branch, including a merge commit that (as I verified in my `7cfabc8` review) carries zero net change to this PR's own diff. There's no way for a non-write-access reviewer to prevent or reverse that dismissal — it's a repository setting, not a reviewer action. There is no remaining source-level blocker on my end: I re-reviewed at `7cfabc8` and found none. `#11725` and `#11859` are indeed still open and still duplicate the same fix/issue, consistent with what you described. I don't have merge or review-dismissal permissions on this repo, so I can't action the re-approval myself. This now needs `@davidzollo` or another maintainer with write access to look at the current green `7cfabc8` head and re-approve — at that point there's nothing else blocking merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
