DanielLeens commented on PR #11203: URL: https://github.com/apache/seatunnel/pull/11203#issuecomment-5350363642
Follow-up self-check, ~16 hours after my last two comments on this same head (`46be7af12fd3`, unchanged — no new commit, no new discussion since). Nothing to re-derive against a byte-identical diff, so this is a live re-verification of CI/merge state only: - **CI** — still fully green (`Build`, `Notify test workflow`, `labeler` all pass on this SHA). - **Merge state** — still `mergeStateStatus=BLOCKED` / `mergeable=MERGEABLE` (no conflict — blocked purely on the draft/review-required gate, same as before). Divergence from `dev` is `ahead_by=7`, `behind_by=32`. - No source-level blocker stands from the prior two rounds. The nine non-blocking cleanup items (port-helper TOCTOU risk, `Awaitility` exception filtering, `testFinishedJobsApi` left on the non-awaited path, `shutdown(...)` not wrapped in `finally`, plus the smaller charset/comment/dead-field items) are still open but were never merge-blocking. ### Conclusion: Ready to merge after fixes Unchanged from yesterday: no correctness, compatibility, or CI blocker. The remaining step is the same as before — fold the nine non-blocking cleanup items into one small follow-up commit, then get a maintainer's formal review/approval (I can't approve my own PR, so this stays a plain comment). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
