zhang-arvin commented on PR #11867: URL: https://github.com/apache/seatunnel/pull/11867#issuecomment-5352192504
@DanielLeens Thanks for the thorough review! I have addressed the key issues: 1. **Issue 1 (composite-key split path dead code)**: Added `getSplitColumns()` override in `MySqlChunkSplitter` and wired up the multi-column hooks (`queryMinMaxMulti`, `queryNextChunkMaxMulti`, `queryMinMulti`, `splitUnevenlySizedChunksMulti`). 2. **Issue 2 (parameter binding count bug for 3+ columns)**: Fixed the lexicographic placeholder-count and parameter-binding logic in `MySqlUtils`. The count formula now correctly derives from the same loop structure used to build the SQL string, and added unit tests for N=2, 3, and 4 columns. 3. **Issue 3 (getSplitType widening)**: Removed unused dead-code helpers (`getSplitColumns(Table)`, `getSplitType(Table)` overloads). 4. **Issue 5 (test coverage)**: Added unit tests for the composite key split scan query with multiple column counts. Please take another look when you have a chance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
